Disable sketch folder deletion #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was too sketchy for most users, we don't need it
…in Russian locale
…in Ukrainian locale
SableRaf
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Looks good to me!
Note: I added auto-generated translations but we could only really verify the French, Italian, and Dutch languages. Others were checked for obvious mistakes, but more detailed proof-reading will be necessary. That said, I think this is good for merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #794
When you delete the last tab in a sketch, Processing treats the entire folder containing the
.pdefile as the sketch folder. This means that if the.pdefile is stored at the root of an important folder (like your Downloads or Desktop folder), deleting it via Processing and confirming the prompt will delete everything in that folder.This causes confusion and has resulted in loss of data for some users. Show a warning message instead.